Ticket #65 (closed defect: fixed)

Opened 6 months ago

Last modified 3 months ago

team results - team name with ' gives error

Reported by: ste Assigned to: ste
Priority: trivial Milestone: 1.2.1
Component: FsComp Version: 1.1.3
Keywords: Cc:

Description (Last modified by ste)

From Mark Graham:

When I generate the team results the team name "l'equipe des gros nez ro" gives a token error for the ' character.... not a big deal (a french man no less).

Will fix. Is a general fault which applies to custom attributes for pilots.

At the moment, the name of an attribute should not have ' in it. Same applies to value of an attribute.

Attachments

Change History

2008-04-15 09:41:06 changed by ste

  • status changed from new to assigned.
  • description changed.

2008-04-15 09:48:19 changed by oyvellef

This is also a potential security problem in the software (Not very likely, but it's still there), it's a good idea to validate all input to make sure it's not any code or wrong characters in there.

FS is Unicode, right?

- Oyvind

2008-04-15 10:00:15 changed by ste

  • status changed from assigned to closed.
  • resolution set to fixed.

unicode yepp.

trouble was not in the xml itself but when using xpath queries.

"l'equipe des gros nez ro" is stored in the fsdb file as
<FsCustomAttribute?? name="team" value="l'equipe des gros nez ro" />
which is ok. Trouble was using xpath query to find it again.

When it comes to the name of a custom attribute, using ' in it is stopped by an xml parse error already in the edit participant dialog.

For v 1.2 I have fixed this so that one can use whatever both for custom attribute names and values.

2008-05-18 12:41:31 changed by

  • milestone deleted.

Milestone 1.2 deleted

2008-05-19 16:49:13 changed by ste

  • milestone set to 1.2.1.

Add/Change #65 (team results - team name with ' gives error)




Action