Opened 7 years ago

Closed 7 years ago

Last modified 6 years ago

#253 closed defect (fixed)

ISO 3166-Alpha3 violation

Reported by: nmajoros Owned by: Joerg Ewald
Priority: trivial Milestone:
Component: FsComp Version: 1.2.14
Keywords: ISO3166 Cc:

Description

Hi,

I programmatically created an FSDB containing a number of swiss pilots. My source database contains the value for the country as per the ISO3166-alpha3 standard, which I then output to the .fsdb

For the Swiss, it should be CHE. But FS doesn't contain CHE, only SUI, and therefore the country is not recognized for these pilots.

I recommend to switch to CHE, while keeping the unassigned SUI for a while

Change History (9)

comment:1 Changed 7 years ago by nmajoros

Additional note: I was notified that FS is using IOC instead of ISO, but then why is the xml attribute called ISO3166-a3 ?

Additionally, supporting both is possible, as they only conflict for BRN which means Brunei or Barhein, but who the hell flies there anyway ?

comment:2 Changed 7 years ago by Joerg Ewald

Found this comment in FS: "As it is FS stores (wrongly) the IOC code in nat_code_3166_a3." We should fix this eventually, but it's only really a problem in the rare circumstances where somebody creates an FSDB file outside of FS, with the ISO codes, and then tries to open that file in FS.

comment:3 Changed 7 years ago by Joerg Ewald

Milestone: 1.4
Resolution: fixed
Status: newclosed

comment:4 Changed 7 years ago by Joerg Ewald

Resolution: fixed
Status: closedreopened

comment:5 Changed 7 years ago by Joerg Ewald

Owner: changed from Stein Tore Erdal to Joerg Ewald
Status: reopenednew

comment:6 Changed 7 years ago by Joerg Ewald

Status: newassigned

comment:7 Changed 7 years ago by Joerg Ewald

Resolution: fixed
Status: assignedclosed

comment:8 Changed 7 years ago by Joerg Ewald

Fixed, will come out with the next release.

The attribute ISO3166_1_a3 will still always contain the IOC codes in files written by FS. But when reading a file, if the value is not an IOC, but an ISO code, we translate it to IOC.

This is mainly because FAI requires the use of IOC codes. The attribute in the FSDB file should be renamed, but I'd rather do that for a major release, along with other changes to the file format.

comment:9 Changed 6 years ago by Joerg Ewald

Milestone: 1.4

Milestone 1.4 deleted

Note: See TracTickets for help on using tickets.