Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#65 closed defect (fixed)

team results - team name with ' gives error

Reported by: Stein Tore Erdal Owned by: Stein Tore Erdal
Priority: trivial Milestone: 1.2.1
Component: FsComp Version: 1.1.3
Keywords: Cc:

Description (last modified by Stein Tore Erdal)

From Mark Graham:

When I generate the team results the team name "l'equipe des gros nez ro" gives a token error for the ' character.... not a big deal (a french man no less).

Will fix. Is a general fault which applies to custom attributes for pilots.

At the moment, the name of an attribute should not have ' in it. Same applies to value of an attribute.

Change History (5)

comment:1 Changed 9 years ago by Stein Tore Erdal

Description: modified (diff)
Status: newassigned

comment:2 Changed 9 years ago by Øyvind Ellefsen

This is also a potential security problem in the software (Not very likely, but it's still there), it's a good idea to validate all input to make sure it's not any code or wrong characters in there.

FS is Unicode, right?

  • Oyvind

comment:3 Changed 9 years ago by Stein Tore Erdal

Resolution: fixed
Status: assignedclosed

unicode yepp.

trouble was not in the xml itself but when using xpath queries.

"l'equipe des gros nez ro" is stored in the fsdb file as
<FsCustomAttribute?? name="team" value="l'equipe des gros nez ro" />
which is ok. Trouble was using xpath query to find it again.

When it comes to the name of a custom attribute, using ' in it is stopped by an xml parse error already in the edit participant dialog.

For v 1.2 I have fixed this so that one can use whatever both for custom attribute names and values.

comment:4 Changed 9 years ago by (none)

Milestone: 1.2

Milestone 1.2 deleted

comment:5 Changed 9 years ago by Stein Tore Erdal

Milestone: 1.2.1
Note: See TracTickets for help on using tickets.