Ticket #65 (closed defect: fixed)

Opened 9 years ago

Last modified 9 years ago

team results - team name with ' gives error

Reported by: ste Owned by: ste
Priority: trivial Milestone: 1.2.1
Component: FsComp Version: 1.1.3
Keywords: Cc:

Description (last modified by ste) (diff)

From Mark Graham:

When I generate the team results the team name "l'equipe des gros nez ro" gives a token error for the ' character.... not a big deal (a french man no less).

Will fix. Is a general fault which applies to custom attributes for pilots.

At the moment, the name of an attribute should not have ' in it. Same applies to value of an attribute.

Change History

comment:1 Changed 9 years ago by ste

  • Status changed from new to assigned
  • Description modified (diff)

comment:2 Changed 9 years ago by oyvellef

This is also a potential security problem in the software (Not very likely, but it's still there), it's a good idea to validate all input to make sure it's not any code or wrong characters in there.

FS is Unicode, right?

  • Oyvind

comment:3 Changed 9 years ago by ste

  • Status changed from assigned to closed
  • Resolution set to fixed

unicode yepp.

trouble was not in the xml itself but when using xpath queries.

"l'equipe des gros nez ro" is stored in the fsdb file as
<FsCustomAttribute?? name="team" value="l'equipe des gros nez ro" />
which is ok. Trouble was using xpath query to find it again.

When it comes to the name of a custom attribute, using ' in it is stopped by an xml parse error already in the edit participant dialog.

For v 1.2 I have fixed this so that one can use whatever both for custom attribute names and values.

comment:4 Changed 9 years ago by anonymous

  • Milestone 1.2 deleted

Milestone 1.2 deleted

comment:5 Changed 9 years ago by ste

  • Milestone set to 1.2.1
Note: See TracTickets for help on using tickets.